feat: change default mode to architect for new installations #5289
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Reordered modes array to put architect mode first - Updated test to reflect architect as the default mode - Maintains backward compatibility for existing users
dosubot
bot
added
size:S
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR sets the default mode to architect for new Roo Code installations by reordering the modes array and updating the corresponding tests.
- Reorders the modes array in src/shared/modes.ts to have architect mode first.
- Updates the test in src/shared/tests/modes.spec.ts to validate that architect mode is now the default.
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/shared/modes.ts | Reorders the modes array to place architect mode at the beginning. |
| src/shared/tests/modes.spec.ts | Adjusts test assertions to reflect architect mode as the default. |
Comments suppressed due to low confidence (1)
src/shared/tests/modes.spec.ts:359
- [nitpick] It might be beneficial to explicitly assert the expected customInstructions value for the architect mode instead of relying on a comment, in order to clearly validate the default configuration.
// The first mode (architect) has its own customInstructions
| customInstructions: | ||
| "1. Do some information gathering (for example using read_file or search_files) to get more context about the task.\n\n2. You should also ask the user clarifying questions to get a better understanding of the task.\n\n3. Once you've gained more context about the user's request, you should create a detailed plan for how to accomplish the task. Include Mermaid diagrams if they help make your plan clearer.\n\n4. Ask the user if they are pleased with this plan, or if they would like to make any changes. Think of this as a brainstorming session where you can discuss the task and plan the best way to accomplish it.\n\n5. Once the user confirms the plan, ask them if they'd like you to write it to a markdown file.\n\n6. Use the switch_mode tool to request that the user switch to another mode to implement the solution.", | ||
| }, | ||
| { |
There was a problem hiding this comment.
[nitpick] Consider adding a brief inline comment explaining that the reordering ensures architect mode is the default for new installations, to improve code clarity for future reviewers.
|
✅ No security or compliance issues detected. Reviewed everything up to cef275a. Security Overview
Detected Code Changes
Reply to this PR with |
daniel-lxs
previously approved these changes
Jun 30, 2025
hannesrudolph
added
the
Issue/PR - Triage
- Update all snapshot tests to reflect architect as the default mode - Fix mode destructuring in validateToolUse tests - All tests now pass with the new default mode configuration
Addresses PR review feedback to clarify that the first mode in the array serves as the default for new installations
The test was using 'Ask' (capitalized) but modes are now lowercase 'ask'. This was causing the test to timeout as the mode validation failed.
daniel-lxs
moved this from PR [Draft / In Progress]
to PR [Needs Prelim Review]
in Roo Code Roadmap
hannesrudolph
added
PR - Needs Preliminary Review
and removed
Issue/PR - Triage
daniel-lxs
approved these changes
Jun 30, 2025
daniel-lxs
moved this from PR [Needs Prelim Review]
to PR [Needs Review]
in Roo Code Roadmap
daniel-lxs
moved this from PR [Needs Review]
to PR [Needs Prelim Review]
in Roo Code Roadmap
daniel-lxs
moved this from PR [Needs Prelim Review]
to PR [Needs Review]
in Roo Code Roadmap
mrubens
approved these changes
Jun 30, 2025
github-project-automation
bot
moved this from PR [Needs Review]
to Done
in Roo Code Roadmap
hannesrudolph
added a commit
that referenced
this pull request
Jul 3, 2025
* feat: change default mode to architect for new installations - Reordered modes array to put architect mode first - Updated test to reflect architect as the default mode - Maintains backward compatibility for existing users * test: update snapshots and fix tests for architect default mode - Update all snapshot tests to reflect architect as the default mode - Fix mode destructuring in validateToolUse tests - All tests now pass with the new default mode configuration * docs: add comment explaining mode ordering for default selection Addresses PR review feedback to clarify that the first mode in the array serves as the default for new installations * fix: Update integration test to use lowercase mode name The test was using 'Ask' (capitalized) but modes are now lowercase 'ask'. This was causing the test to timeout as the mode validation failed.
utarn
pushed a commit
to modelharbor/ModelHarbor-Agent
that referenced
this pull request
Jul 4, 2025
…Inc#5289) * feat: change default mode to architect for new installations - Reordered modes array to put architect mode first - Updated test to reflect architect as the default mode - Maintains backward compatibility for existing users * test: update snapshots and fix tests for architect default mode - Update all snapshot tests to reflect architect as the default mode - Fix mode destructuring in validateToolUse tests - All tests now pass with the new default mode configuration * docs: add comment explaining mode ordering for default selection Addresses PR review feedback to clarify that the first mode in the array serves as the default for new installations * fix: Update integration test to use lowercase mode name The test was using 'Ask' (capitalized) but modes are now lowercase 'ask'. This was causing the test to timeout as the mode validation failed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR changes the default mode for new Roo Code installations from "code" to "architect" mode, as requested.
Changes Made
src/shared/modes.tsto put architect mode firstsrc/shared/__tests__/modes.spec.tsto reflect that architect is now the default modeImplementation Details
The change was implemented using the simple approach suggested - just reordering the modes array rather than adding complex logic. This ensures:
Testing
defaultModeSlugcorrectly points to "architect"Checklist
Important
Changes default mode to "architect" for new installations by reordering the
modesarray and updates tests accordingly.modesarray inmodes.ts.modes.spec.tsto reflect "architect" as default mode.defaultModeSlugpoints to "architect".validateToolUse.spec.tsfor mode validation.This description was created by
for cef275a. You can customize this summary. It will automatically update as commits are pushed.